* inline image/text expansion on applicable posts (by far the most impactful and time consuming) * edit now preserves your new edited text if you fail the captcha * fixed a captcha bug * when linking directly to comments, the comment-reply box is hidden by default * edit post/comment box now is MUCH larger * the post-reply box now has a higher minimum size for browsers that don't support -webkit-fill-avaliable * fixed a xss bug when editing comments (only the user editing the comment would be effected so this wasn't too serious) * individual post/comment pages should look MUCH better on mobile devices. the thumbnail is hidden now on all types of posts, not just posts with thumbnails, below a certain resolution.
i'm done for the night.
Hi, this is a progress update, I was occupied for most of the day yesterday so I wasn't able to put in quite the same amount of time I had previously.
What's coming today: image expansion, (possible? limited?) video expansion, comment-box hiding for default when linking to individual comments (for JS users. non-js users will still see the reply box). Auto-hotlinking of links (old markup format will also work).
Let's get to it, shall we?
EDIT: Also, when editing this comment, I noticed that if I fail to type in the captcha, my entire edit is erased. This is fucking annoying and I will be fixing this too.
Edit2: the bug that some mobile users have encountered with overlapping text,
Edit3: there is a bug for users who use browsers which don't support the -webkit-fill-avaliable css width styling. Comment reply boxes are showing up WAY smaller than they should be. I've noticed it on IE, but users have also reported this occurring on some browsers when running linux This also is being addressed today.
I will provide progress updates in real time to this thread as comments as things are completed.
On the agenda tomorrow, or late today if I'm somehow able to implement these fixes/updates in far less time than I estimate they will take, is email functionality, mainly for password resets. This platform currently runs on Google cloud, which blocks outgoing port 25 (email) by default, so I will have to use an external service to send emails. This is the reason this functionality has not yet been implemented.
I was locked out of my own admin account on my mobile phone after forgetting my password, so I have personal experience with the importance of this feature :)
Edit 4: I'm also exploring increasing the comment depth displayed by default to a number greater than 5. I've noticed that most users do not use the "more" link to view comment threads which extend past 5 levels deep. While I think the "more >>>" link not being very visible contributes to this (I myself often miss it) which will be adjusted, I think displaying more comments in general encourages discussion. The reason comments are only visible to 5 levels deep initially is due to the limited amount of space afforded by low resolution, portait-mode devices. I will have to address this design limitation, when raising the maximum comment-reply depth, which might require some re-imagining in the basic layouts of comments. We'll see, though. Since comment threads extending to this depth are currently relatively rare, simply rendering later comments with less vertical space may be a perfectly valid option.
[05/Oct/2019:14:14:08 +0000] "GET /r/OMITTED/undefined HTTP/1.1" 404 209 "https://ieddit.com/r/OMMITTED/" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36"
Additionally, I keep seeing requests like these showing up in the logs. I believe this may be caused by browser addons, as I utilize a bare minimum of javascrip so 'undefined' REALLY should not being showing up in any requests. That being said, it is still a possibility this bug is being caused by something I have done.
Any users who encounter this, please comment/message me as to the details of how you encountered these URLs with 'undefined' in them, and which browser/addons you may be using.
inline images/text (by far the most impactful) edit now preserves your new edited text if you fail the captcha fixed a captcha bug when linking directly to comments, the comment-reply box is hidden by default
I would HIGHLY recommend against image expansion. What happens when this site gets flooded by illegal photos of children? Or live executions? Do you really want to serve time in prison for the sake of this project? Let imgur manage those risks
Even now, if someone were to illegally dox a user or declare an actionable death threat, all we can do is mark it NSFW
The code I already have written for thumbnails: 1. first checks if the url has a image/x content type. if so, that image is used as thumbnail. 2. if it isn't a direct image, it looks for the og:image opengraph tag, and then fetches the images from the og:image url. 3. if that fails, it just trys its best to find the largest image in the page source.
in case 1 or 2, if an image is found, I'd store that link in a "remote_image_url" column, for the post. the way expansion would work, is whenever a user clicks to expand an image, it actually will just add an element. I would not be hosting any full-size images on the site.
* inline image/text expansion on applicable posts (by far the most impactful and time consuming)
* edit now preserves your new edited text if you fail the captcha
* fixed a captcha bug
* when linking directly to comments, the comment-reply box is hidden by default
* edit post/comment box now is MUCH larger
* the post-reply box now has a higher minimum size for browsers that don't support -webkit-fill-avaliable
* fixed a xss bug when editing comments (only the user editing the comment would be effected so this wasn't too serious)
* individual post/comment pages should look MUCH better on mobile devices. the thumbnail is hidden now on all types of posts, not just posts with thumbnails, below a certain resolution.
i'm done for the night.
Hi, this is a progress update, I was occupied for most of the day yesterday so I wasn't able to put in quite the same amount of time I had previously.
What's coming today: image expansion, (possible? limited?) video expansion, comment-box hiding for default when linking to individual comments (for JS users. non-js users will still see the reply box). Auto-hotlinking of links (old markup format will also work).
Let's get to it, shall we?
EDIT: Also, when editing this comment, I noticed that if I fail to type in the captcha, my entire edit is erased. This is fucking annoying and I will be fixing this too.
Edit2: the bug that some mobile users have encountered with overlapping text,
Edit3: there is a bug for users who use browsers which don't support the -webkit-fill-avaliable css width styling. Comment reply boxes are showing up WAY smaller than they should be. I've noticed it on IE, but users have also reported this occurring on some browsers when running linux This also is being addressed today.
I will provide progress updates in real time to this thread as comments as things are completed.
On the agenda tomorrow, or late today if I'm somehow able to implement these fixes/updates in far less time than I estimate they will take, is email functionality, mainly for password resets. This platform currently runs on Google cloud, which blocks outgoing port 25 (email) by default, so I will have to use an external service to send emails. This is the reason this functionality has not yet been implemented.
I was locked out of my own admin account on my mobile phone after forgetting my password, so I have personal experience with the importance of this feature :)
Edit 4: I'm also exploring increasing the comment depth displayed by default to a number greater than 5. I've noticed that most users do not use the "more" link to view comment threads which extend past 5 levels deep. While I think the "more >>>" link not being very visible contributes to this (I myself often miss it) which will be adjusted, I think displaying more comments in general encourages discussion. The reason comments are only visible to 5 levels deep initially is due to the limited amount of space afforded by low resolution, portait-mode devices. I will have to address this design limitation, when raising the maximum comment-reply depth, which might require some re-imagining in the basic layouts of comments. We'll see, though. Since comment threads extending to this depth are currently relatively rare, simply rendering later comments with less vertical space may be a perfectly valid option.